Re: [Libguestfs] Cargo edition problem with Debian 11
On Fri, Jan 13, 2023 at 06:34:29PM +0000, Richard W.M. Jones wrote:
> https://github.com/libguestfs/nbdkit/pull/19
Actually I suspect that the changes made in PR19 will get overwritten
since they touch files which are in git but are really controlled by
libvirt-ci.
I'm not sure how to make the changes in a way which are compatible
with libvirt-ci, maybe Eric or others can help with that.
Rich.
So,
I looked at the PR and don't see any files that would be overwritten by
lcitool as none of the 3 (plugins/..., .cirrus.yml) are managed by lcitool, so
from that perspective, it's safe.
I read the whole conversation and if I understand the problem well, Debian
ships an old Rust toolchain which doesn't play well with the latest crate
dependencies you specify (? Sorry if I got it wrong, I know nothing about
Rust).
In any case, the change I'm seeing in the PR 19:
rustc --version | grep -q 1.46.0 && mv plugins/rust/Cargo.lock.msrv
plugins/rust/Cargo.lock
doesn't really cover the 1.48.0 version on Debian, does it? I guess you'll have
to improve the Bash check to cover all affected Rust versions. Looking at your
autotools Makefiles, to fix this for all platforms you run as part of the CI,
the fix IIUC needs to go to plugins/rust/Makefile.am not to anything lcitool
manages - disabling Debian as a platform from building nbdkit stuff with Rust
even though a simple workaround exists seems the wrong approach to me.
Regards,
Erik