Re: [Libguestfs] [PATCH nbdkit 1/5] src: Mark synopsis.c as BUILT_SOURCES.
On 12/6/18 3:50 PM, Richard W.M. Jones wrote:
---
src/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/Makefile.am b/src/Makefile.am
index 3490c0f..65f9498 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -80,6 +80,7 @@ nbdkit_LDFLAGS = \
# synopsis.c is generated from docs/synopsis.txt where it is also
# used to generate the man page. It is included in main.c.
+BUILT_SOURCES = synopsis.c
EXTRA_DIST = synopsis.c
nbdkit_DEPENDENCIES = synopsis.c
CLEANFILES += synopsis.c
Did this make an actual difference during parallel 'make', given that
you already have nbdkit_DEPENDENCIES to trigger normal make
prerequisites? Automake's implementation of BUILT_SOURCES states that
they will be rebuilt even when Makefile itself is out of date (because
configure.ac or Makefile.am was touched, for example), which is really
early in the process (and annoying when trying to use tab completion to
learn what targets make supports, since BUILT_SOURCES are built prior to
computing what output to present). But while it might be annoying, I'm
not opposed to the patch, especially if you did hit a situation in this
series where it mattered.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org