On Thu, Sep 17, 2020 at 01:39:56PM +0100, Richard W.M. Jones wrote:
As discussed in the emails today, this is the third version
addressing
most points from the v1/v2 review.
You will need to pair this with the changes in libguestfs-common from
this series:
https://www.redhat.com/archives/libguestfs/2020-September/msg00050.html
I'm going to look at this, but I do not have a machine to try this on, so I will
not be able to do any functional testing (i.e. the review will be very much
incomplete). But from my limited testing I can tell you it breaks the build for
me with the following errors:
Making all in golang
make[2]: Entering directory '/home/nert/dev/libguestfs/golang'
../run go install
libguestfs.org/guestfs
#
libguestfs.org/guestfs
src/libguestfs.org/guestfs/guestfs.go:3964:34: could not determine kind of name for
C.GUESTFS_CRYPTSETUP_OPEN_CRYPTTYPE_BITMASK
src/libguestfs.org/guestfs/guestfs.go:3960:34: could not determine kind of name for
C.GUESTFS_CRYPTSETUP_OPEN_READONLY_BITMASK
src/libguestfs.org/guestfs/guestfs.go:3925:10: could not determine kind of name for
C.guestfs_cryptsetup_close
src/libguestfs.org/guestfs/guestfs.go:3970:10: could not determine kind of name for
C.guestfs_cryptsetup_open_argv
make[2]: *** [Makefile:2509:
pkg/linux_amd64/libguestfs.org/guestfs.a] Error 2
make[2]: Leaving directory '/home/nert/dev/libguestfs/golang'
so just so you know before I get to looking at the code.
Have a nice day,
Martin
Rich.
_______________________________________________
Libguestfs mailing list
Libguestfs(a)redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs