Re: [Libguestfs] [PATCH 2/5] macosx: Add definition of program_name for gnulib

On 11 February 2015 at 19:23, Richard W.M. Jones <rjones(a)redhat.com&gt; wrote: > On Wed, Feb 11, 2015 at 07:20:33PM +0000, Margaret Lewicka wrote: [...] >> Proposing a patch to gnulib, even should they accept it, does not fix >> the underlying issue, which is, essentially, that gnulib requires that >> symbol and libguestfs binaries don't supply it. There might be another >> OS that trips over this, after all. > > But it would fix it for Mac OS X, which is better than nothing. > > As a test, can you see if adding some variation of: > > #if /* this is Mac OS X */ > #define program_name (((char **)*_NSGetArgv())[0]) > #endif > > to libguestfs's gnulib/lib/error.h fixes the problem? > > It'll save you a lot of time if it does work. It compiles and libguestfs-test-tool doesn't bomb afterwards, if that is a sufficient definition of "working".