Re: [Libguestfs] [p2v PATCH 7/7] gui.c: annotate GTK_INPUT_PURPOSE_PASSWORD with upstream GTK3 version
On 09/26/22 13:59, Richard W.M. Jones wrote:
Apart from Dan's suggestions in patch 1, the series looks good to me.
I've updated patch#1 (both the code and the commit message), and pushed
the series (28d7ce8c9db9..94f1f9df1994), taking your above statement as
an ACK (hope that's OK).
Because of the update to patch#1, I also retested the shutdown button /
action in the last dialog; for that I needed to go through a full in-VM
conversion... Hrmpf. :)
FWIW RHEL 7 (the earliest distro with PCRE 2) has glib2 2.56.1 &
gtk3 3.22.30, so supporting any earlier versions also seems pointless,
so that might be another thing to review. We could make USE_POPOVERS
unconditional, and make gui-gtk3-compat.h considerably less
complicated.
I'd like to look into the GTK3 simplification separately from this
series; I expect a few nuances here and there, so I wanted to sync the
GTK2 removal to the master branch at first.
Laszlo