Re: [Libguestfs] [PATCH v6 0/1] v2v bootloaders and augeas

On Fri, Apr 28, 2017 at 07:58:41PM +0300, Pavel Butsykin wrote: > > > On 28.04.2017 17:46, Pino Toscano wrote: >> On Wednesday, 19 April 2017 15:58:56 CEST Pavel Butsykin wrote: >>> I dare to raise an old topic :) It seemed to me that this patch already applied, >>> but recently discovered that it is not. >>> >>> As far as I understand we can't do a strict requirement to use Augeas >= 1.7.0. >>> But initially, the patch solves another problem. If we still can't do a hard >>> requirement for Augeas, let's use workaround proposed by Pino: >>> let () = >>> (* Apply the "grub" lens if it is not handling the file >>> * already -- Augeas < 1.7.0 will error out otherwise. >>> *) >>> if g#aug_ls ("/files" ^ grub_config) = [||] then >>> g#aug_transform "grub" grub_config in >>> >>> As a temporary solution looks fine. >> >> Better this solution than raising the Augeas requirements, for now. >> > > Rich, What about workaround? I guess. I disagree with Pino on this, but he knows the topic better. Is there a final patch ready to apply now? I think lost the beginning of this thread.

Rich.