On 3/28/19 11:18 AM, Richard W.M. Jones wrote:
This has already been pushed upstream. I am simply posting these
here
so we have a reference in the mailing list in case we find bugs later
(as I'm sure we will - it's a complex patch series).
Great thanks to Eric Blake for tireless review on this one. It also
seems to have identified a few minor bugs in qemu along the way.
We missed the nozero filter - when using the filter to change whether
the client can see sparse handling extensions, we should probably have a
way to force the entire image to appear as allocated (and NOT as zero)
in order to time the client actually reading things (rather than a
client that reads block status and then skips what it knows are holes in
spite of us not allowing them to write zeroes).I don't know if it needs
another knob independent from zeromode, or if it should just be a third
mode, or if we can just wrap that into the existing zeromode=none.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization:
qemu.org |
libvirt.org