Re: [Libguestfs] [PATCH common 3/4] mltools: Introduce priority for ordering actions in On_exit
On Fri, Jul 15, 2022 at 09:17:26AM +0200, Laszlo Ersek wrote:
I think this patch is good, but I'm surprised that ~prio:0 is
for
placing stuff at the *end* of the list, where 1000 is the default. This
ordering differs from both the firstboot script priorities we did
recently (lower prio number -> runs earlier) and also from the operation
ordering in virt-sysprep (default is 0, 99 puts stuff at the end).
Swapping around the arguments to "compare" wouldn't be difficult, the
more laborious update would be for the documentation (commit message,
comments). Up to you...
Reviewed-by: Laszlo Ersek <lersek(a)redhat.com>
So, here's the change to libguestfs-common:
https://github.com/libguestfs/libguestfs-common/commit/290a2cecbe679660de...
https://github.com/libguestfs/libguestfs-common/commit/1000604ff391e49f0b...
Priorities are 0..9999 (limit is not actually enforced) with higher
numbers running later and 5000 being the default.
The change to virt-v2v:
https://github.com/libguestfs/virt-v2v/commit/e96357fc3b26aaf96eaa21afa36...
I don't think there are other places where we umount host devices, but
I'm sure there are other places that could use On_exit priorities (in
guestfs-tools as well). Let's keep an eye out for those.
Thanks,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html