Re: [Libguestfs] [PATCH v3 4/6] mllib: modify nsplit to take optional noempty and count arguments
On Fri, Dec 09, 2016 at 10:52:23AM +0100, Pino Toscano wrote:
On Wednesday, 7 December 2016 17:13:08 CET Tomáš Golembiovský wrote:
> Added two new optional arguments to nsplit:
>
> * noempty: if set to false empty elements are not stored in the returned
> list. The default is to keep the empty elements
>
> * count: specifies how many splits to perform; negative count
> (the default) means do as many splits as possible
>
> Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
> ---
LGTM -- while you are here, what about adding tests for it in
mllib/common_utils_tests.ml?
It definitely needs tests.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top