Re: [Libguestfs] [PATCH] sparsify: skip test-virt-sparsify-in-place.sh if discard is not supported

I don't like spinning up an appliance in order to test a feature. Although it's quick on baremetal, inside Koji it takes 10+ seconds, so it adds to the already lengthy test times. So, see the patch series I have just posted. There are actually loads of places in the library code where we return an 'unsupported' indication or error message, but we don't set the errno to ENOTSUP. Many of the following locations (and likely others too) could be fixed to set errno to ENOTSUP: $ git grep -iE '\b(supp|unsupp)' -- src | wc -l 131 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org