Re: [Libguestfs] Figuring out some failing tests for libnbd

On Wed, Jul 07, 2021 at 12:23:28PM +0200, Martin Kletzander wrote: > On Tue, Jul 06, 2021 at 09:06:13AM +0100, Richard W.M. Jones wrote: > >On Wed, Jun 30, 2021 at 05:07:31PM +0100, Richard W.M. Jones wrote: > >>https://gitlab.com/nertpinx/libnbd/-/jobs/1389193577 > >> > >>This has dozens of failures in the OCaml tests. Most but not > >>all of them are like this: > >> > >>==20650== 16 bytes in 1 blocks are still reachable in loss record 1 of 38 > >>==20650== at 0x483E7B5: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) > >>==20650== by 0x47239C: caml_stat_alloc_noexc (memory.c:818) > >>==20650== by 0x47239C: caml_stat_alloc (memory.c:840) > >>==20650== by 0x485BCD: caml_register_custom_operations (custom.c:121) > >>==20650== by 0x485BCD: caml_init_custom_operations (custom.c:163) > >>==20650== by 0x48BE46: caml_startup_common (startup_nat.c:132) > >>==20650== by 0x48C05A: caml_startup_exn (startup_nat.c:163) > >>==20650== by 0x48C05A: caml_startup (startup_nat.c:168) > >>==20650== by 0x48C05A: caml_main (startup_nat.c:175) > >>==20650== by 0x430CEB: main (main.c:41) > > > >I took a proper look at this issue last night and it should be fixed > >in these two commits: > > > >https://gitlab.com/nbdkit/nbdkit/-/commit/99140272a0675b3d123d2c42cb0a5ab73b09fba2 > >https://gitlab.com/nbdkit/nbdkit/-/commit/875a5056758dca754225f49516a0f4c8e788ac94 > > > > Yes, looks like it is, thanks. I also figured out the last failing test > and if it goes well I will push those ACKed from the last week and send > the last one to finally get the pipeline all green. I realised now this is libnbd - my fixes went into nbdkit. However the equivalent fix for libnbd should work too.

Rich. > >Rich. > > > >-- > >Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones > >Read my programming and virtualization blog: http://rwmj.wordpress.com > >virt-top is 'top' for virtual machines. Tiny program with many > >powerful monitoring features, net stats, disk stats, logging, etc. > >http://people.redhat.com/~rjones/virt-top > > -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v