Re: [Libguestfs] [PATCH 1/2] launch: Rationalize how we construct the Linux kernel command line.

On Sunday, 18 December 2016 20:09:28 CET Richard W.M. Jones wrote: Mostly LGTM, just one note. Currently, safe_asprintf aborts on ENOMEM errors, while guestfs_int_join_strings just returns NULL on that situation -- most probably the abort callback needs to be invoked manually: char *ret; ... ret = guestfs_int_join_strings (" ", argv.argv); if (ret == NULL) g->abort_cb (); return ret; Thanks, -- Pino Toscano