Re: [Libguestfs] virt-v2v: default graphics driver for SUSE guests

Hi Pino, On 2/26/19 5:52 PM, Mike Latimer wrote: After a bit of checking, defaulting to qxl for SUSE guests is a better choice, and should work fine for all versions we expect to encounter in the wild. Do you mind pulling this out yourself, or would you prefer I submit a patch containing this change? I've moved on to other things, and really only have enough bandwidth for a minimal change like: diff -Nurp a/v2v/convert_linux.ml b/v2v/convert_linux.ml --- a/v2v/convert_linux.ml    2019-02-28 16:30:58.668800431 -0700 +++ b/v2v/convert_linux.ml    2019-02-28 16:33:14.729907825 -0700 @@ -104,7 +104,7 @@ let convert (g : G.guestfs) inspect sour        let video =        match rcaps.rcaps_video with -      | None -> get_display_driver () +      | None -> QLX        | Some video -> video in        let block_type = @@ -771,9 +771,6 @@ let convert (g : G.guestfs) inspect sour      else        true   -  and get_display_driver () = -    if family = `SUSE_family then Cirrus else QXL -    and configure_display_driver video =      let video_driver = match video with QXL -> "qxl" | Cirrus -> "cirrus" in I'd be happy to submit this as an official patch, or just let you do it with some of your planned changes. Thanks! Mike