Re: [Libguestfs] [PATCH] New API: resize2fs_P
Hi,
On Wednesday 14 October 2015 12:53:26 Maxim Perevedentsev wrote:
This multiplication may confuse users who got used to
"normal" resize2fs
-P behavior (blocks) due to the name of API command.
I'm going to implement similar functionality for other filesystems
(ntfs, btrfs, xfs).
Then please implement a single function for all these filesystems,
just like set_label, set_uuid, etc. Having to call a different function
to get the same information depending on the filesystem is only making
artificial barriers in users of the API (which then have to do the
function choice at runtime on their own).
I think we should preserve original command's behavior
(well-documented,
obviously!) and leave the conversion between blocks, megabytes, etc to user.
Maybe (later) we could implement aggregated call (getMinFsSizeInBytes())
to perform all this conversions.
Please note the API is there also to provide some coherency.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)