Libguestfs October 2013

guestfs@lists.libguestfs.org

14 participants
34 discussions

Hivex - Trailing garbage at the end of hive file

by Richard W.M. Jones

[Forwarding to the proper list] We use hivex for one of our projects and I see the following diff committed to the hivex project (source link provided) that ignores trailing garbage. But this code has been reverted to no ignore this condition in later version of hivex - /* This error is seemingly common in uncorrupt registry files. */ - /* - fprintf (stderr, "hivex: %s: ignoring trailing garbage at end of file (at %zu, after %zu pages)\n", - filename, off, h->pages); - */ + /* NB: This error is seemingly common in uncorrupt registry files. */ + if (h->msglvl >= 2) + fprintf (stderr, "hivex: %s: ignoring trailing garbage at end of file (at %zu, after %zu pages)\n", + filename, off, h->pages); Break; http://git.annexia.org/?p=hivex.git;a=commitdiff;h=5439842dc591accbf620a5... In your experience, is this a common condition seen in some windows hive files and is it safe to ignore when this condition is encountered? Thanks ~ Hari --------- -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org

11 years, 1 month

2
10
0 / 0

Plan for libguestfs 1.24

by Richard W.M. Jones

It has been 5 months since the last stable release of libguestfs and over that time we've accumulated many exciting new features. It's time to plan for the release of libguestfs 1.24. As usual, bugs which have "1.24" (without quotes) in the Devel Whiteboard field in Bugzilla are nominated as blockers for the release. You can see a list of those here, currently empty: https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&bug_status=ASSIGNE... or http://tinyurl.com/owhm42j For a list of all bugs, go to: https://bugzilla.redhat.com/buglist.cgi?component=libguestfs&product=Virt... If there are any other features / blockers / problems that need to be addressed, let me know. This release will also be the basis for Fedora 20 and RHEL 7.x (x ?= 1). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW

11 years, 1 month

1
0
0 / 0

[PATCHp2v v2] virt-p2v-server: Die with the correct error message.

by Richard W.M. Jones

From: "Richard W.M. Jones" <rjones(a)redhat.com> Although the code is technically correct (because the successful call to $g->close won't overwrite $@ and because guestfs_close can never fail) it's still confusing to assign $err = $@ and then not use $err. Die with $err. It's possible something added here could overwrite $@ at some later time. --- p2v/server/virt-p2v-server.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2v/server/virt-p2v-server.pl b/p2v/server/virt-p2v-server.pl index c15efb2..0121ab2 100755 --- a/p2v/server/virt-p2v-server.pl +++ b/p2v/server/virt-p2v-server.pl @@ -405,7 +405,7 @@ sub convert my $err = $@; $g->close() if defined($g); - die($@); + die($err); } p2v_return_ok(); -- 1.8.3.1

11 years, 1 month

1
0
0 / 0

[PATCHp2v] virt-p2v-server: Die with the correct error message.

by Richard W.M. Jones

From: "Richard W.M. Jones" <rjones(a)redhat.com> This caused the real error to be hidden, resulting in the famous and uninformative: virt-v2v: Died at /usr/bin/virt-p2v-server line 404, <> line 7. --- p2v/server/virt-p2v-server.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2v/server/virt-p2v-server.pl b/p2v/server/virt-p2v-server.pl index c15efb2..0121ab2 100755 --- a/p2v/server/virt-p2v-server.pl +++ b/p2v/server/virt-p2v-server.pl @@ -405,7 +405,7 @@ sub convert my $err = $@; $g->close() if defined($g); - die($@); + die($err); } p2v_return_ok(); -- 1.8.3.1

11 years, 1 month

1
0
0 / 0

← Newer
1
2
3
4
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

Libguestfs October 2013