9:03 a.m.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
11:49 a.m.
Richard W.M. Jones wrote:
Subject: [PATCH 5/7] daemon/Win32: Windows replacement for umask.
---
daemon/guestfsd.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c
index 64cf87f..40b3c2f 100644
--- a/daemon/guestfsd.c
+++ b/daemon/guestfsd.c
@@ -182,8 +182,16 @@ main (int argc, char *argv[])
setenv ("SHELL", "/bin/sh", 1);
setenv ("LC_ALL", "C", 1);
+#ifndef WIN32
/* We document that umask defaults to 022 (it should be this anyway). */
umask (022);
+#else
+ /* This is the default for Windows anyway. It's not even clear if
+ * Windows ever uses this -- the MSDN documentation for the function
+ * contains obvious errors.
+ */
+ _umask (0);
+#endif
Same idea here:
#ifdef WIN32
static inline mode_t
umask (mode_t mode)
{
_umask (0);
}
#endif
12:54 p.m.
On Wed, Nov 25, 2009 at 06:49:41PM +0100, Jim Meyering wrote:
Richard W.M. Jones wrote:
> Subject: [PATCH 5/7] daemon/Win32: Windows replacement for umask.
>
> ---
> daemon/guestfsd.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c
> index 64cf87f..40b3c2f 100644
> --- a/daemon/guestfsd.c
> +++ b/daemon/guestfsd.c
> @@ -182,8 +182,16 @@ main (int argc, char *argv[])
> setenv ("SHELL", "/bin/sh", 1);
> setenv ("LC_ALL", "C", 1);
>
> +#ifndef WIN32
> /* We document that umask defaults to 022 (it should be this anyway). */
> umask (022);
> +#else
> + /* This is the default for Windows anyway. It's not even clear if
> + * Windows ever uses this -- the MSDN documentation for the function
> + * contains obvious errors.
> + */
> + _umask (0);
> +#endif
Same idea here:
#ifdef WIN32
static inline mode_t
umask (mode_t mode)
{
_umask (0);
}
#endif
Windows, being Windows, has umask as well :-(
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v
1:18 p.m.
Richard W.M. Jones wrote:
On Wed, Nov 25, 2009 at 06:49:41PM +0100, Jim Meyering wrote:
> Richard W.M. Jones wrote:
> > Subject: [PATCH 5/7] daemon/Win32: Windows replacement for umask.
> >
> > ---
> > daemon/guestfsd.c | 8 ++++++++
> > 1 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c
> > index 64cf87f..40b3c2f 100644
> > --- a/daemon/guestfsd.c
> > +++ b/daemon/guestfsd.c
> > @@ -182,8 +182,16 @@ main (int argc, char *argv[])
> > setenv ("SHELL", "/bin/sh", 1);
> > setenv ("LC_ALL", "C", 1);
> >
> > +#ifndef WIN32
> > /* We document that umask defaults to 022 (it should be this anyway). */
> > umask (022);
> > +#else
> > + /* This is the default for Windows anyway. It's not even clear if
> > + * Windows ever uses this -- the MSDN documentation for the function
> > + * contains obvious errors.
> > + */
> > + _umask (0);
> > +#endif
>
> Same idea here:
>
> #ifdef WIN32
> static inline mode_t
> umask (mode_t mode)
> {
> _umask (0);
> }
> #endif
Windows, being Windows, has umask as well :-(
In that case, this should work:
#ifdef WIN32
# define umask(m) rpl_umask(m)
static inline mode_t
rpl_umask (mode_t mode)
{
_umask (0);
}
#endif
5481
days inactive
5481
days old
3 comments
2 participants
participants (2)
-
Jim Meyering -
Richard W.M. Jones