Richard W.M. Jones wrote:
>From 4d86861feb312fda6d366e2bd067bcc58470c1e0 Mon Sep 17 00:00:00
2001
From: Richard Jones <rjones(a)trick.home.annexia.org>
Date: Thu, 17 Sep 2009 14:49:06 +0100
Subject: [PATCH 2/5] 'len' should be an unsigned 32 bit int.
This only happened to work by accident before because 'unsigned len'
happens to be 32 bit on all platforms we support.
---
daemon/proto.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/daemon/proto.c b/daemon/proto.c
index d935ded..431f219 100644
--- a/daemon/proto.c
+++ b/daemon/proto.c
@@ -45,7 +45,7 @@ main_loop (int _sock)
XDR xdr;
char *buf;
char lenbuf[4];
- unsigned len;
+ uint32_t len;
Good one. ACK
It'd be good to find any others like that, and
to add automatic syntax-style check.
I think it'd be pretty easy to do with coccinelle.
http://coccinelle.lip6.fr/