Richard W.M. Jones wrote: ... This looks fine (in spite of having to write "- -" for "--" above ;-), so ACK.

Richard W.M. Jones wrote: ... ... There's no need to add these in EXTRA_DIST, since... ...adding them in dist_doc_DATA already ensures they're distributed (the "dist_" prefix). This is a cute trick, and is fine if you're confident this is the only type of test there will ever be in this subdirectory. Otherwise, you might want to change it to generate tiny scripts to accomplish the same task in a way that will accommodate non-xml-related tests. E.g., something like this: ----------------------------------------------------------------------------- xml = example1.xml example2.xml example3.xml example4.xml xml_sh = $(subst .xml,.sh,$(xml)) TESTS = $(xml_sh) DISTCLEANFILES = $(xml_sh) z = $(subst .sh,.xml,$@) $(xml_sh): Makefile ( printf '%s\n' '#!/bin/sh' \ 'exec $(XMLLINT) --noout --relaxng virt-inspector.rng $(z)'; \ ) > $@-t && chmod a+x $@-t && mv $@-t $@ ----------------------------------------------------------------------------- Regarding conditional tests, how about running them unconditionally, but making them skip with a diagnostic when xmllint is not available, e.g., insert two more lines into each generated script: ( xmllint --version > /dev/null 2>&1 ) \ || { echo "$0: skipping this test: xmllint is not available" exit 77; } Then even if xmllint is not around at configure-time, but is later installed, the tests *will* be run. If you do this, you can drop the configure-time test, of course.