Re: [Libguestfs] [libnbd RFC PATCH] First stab at CI infrastructure

On Wed, Apr 07, 2021 at 05:49:30PM +0100, Richard W.M. Jones wrote: Well, any question you might have I'll do my best to answer it. It took me a while as well, but it is way more versatile and stable than other CI setups. I did not really check more than just running the tests, but if there is any workflow that you have, then we can incorporate it in there, so that it checks as much as possible. I tried running `make distcheck` and there were some harder failures than these, so I wanted to start small. Good to know. I started with the list from libvirt (which is the most complete I know) and figured we will tune it later. I'm removing the mingw builds then, thanks. There are couple more, but they are the same failure. Basically anything that builds with clang (BSD and MacOS by default and CentOS 8 is running both GCC and clang variants) will error out due to unused string vector functions. Unfortunately those are generated. Example: https://gitlab.com/nertpinx/libnbd/-/jobs/1140619387 GCC does not find this even with --enable-gcc-warnings (already used). One last thing that I forgot to mention, but I definitely wanted to ask about is whether there is a reason behind not erroring out when some configure option is requested, but cannot be fulfilled. For example `--with-libxml2` when pkg-config cannot find it will just result in a warning that most people will miss. If new dependencies are required and we forget to add them to the list of packages for CI, then instead of the CI failing and us noticing pretty quickly we will just build without the support for some part of the code and completely missing it in the tests as well. Anyway, I updated some details and ran it again: https://gitlab.com/nertpinx/libnbd/-/pipelines/283351379 Let's see what's going to pop up next.