On Tue, Nov 07, 2017 at 02:57:50PM +0100, Pino Toscano wrote:
On Tuesday, 17 October 2017 17:35:51 CET Richard W.M. Jones wrote:
> The immediate issue is with Fedora/ppc64 and /ppc64le which currently
> use extended partitions, breaking the virt-builder ‘--size’ parameter,
> eg:
>
> $ virt-builder --arch ppc64le fedora-26 --size 20G
> ...
> [ 21.6] Resizing (using virt-resize) to expand the disk to 20.0G
> virt-resize: error: /dev/sda5: partition not found in the source disk image
> (this error came from '--expand' option on the command line). Try
running
> this command: virt-filesystems --partitions --long -a /var/tmp/vbf67b8c.img
>
> However more generally MBR is broken and should die. GPT is supported
> by all modern virtual bootloaders, so just default to it.
>
> Notes:
>
> * This is different from mandating a UEFI bootloader.
>
> * I am not planning to rebuild any existing images except the
> F26 ppc64 & ppc64le ones.
> ---
The reasons above suggest me that we should switch all the distros (in the
libguestfs.org repository) to GPT, not just the ones in this patch.
I agree, although that's a bit more work as I'd have to work out how
to actually do that for the other distros.
This change fixes a concrete problem with Fedora/ppc64 which affects
us right now (with an open bug IIRC).
I'm not proposing to rebuild old images (except Fedora 26/ppc64*)
in any case.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html