Re: [Libguestfs] [nbdkit PATCH] test-layers: Avoid thread leak

Running 'make check' under a ThreadSanitizer build complains that test-layers leaks a pthread; while harmless, it is also an easy fix, by detaching the thread to ensure it gets cleaned up. Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; --- tests/test-layers.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/test-layers.c b/tests/test-layers.c index 00e6031..7b58699 100644 --- a/tests/test-layers.c +++ b/tests/test-layers.c @@ -152,6 +152,12 @@ main (int argc, char *argv[]) perror ("pthread_create"); exit (EXIT_FAILURE); } + err = pthread_detach(&thread);

+ if (err) { + errno = err; + perror ("pthread_detach"); + exit (EXIT_FAILURE); + } /* Note for the purposes of this test we're not very careful about * checking for errors (except for the bare minimum) or handling the