Re: [Libguestfs] [PATCH 09/11] appliance: fix errors in init for SLE / openSUSE
On Thursday 12 May 2016 15:29:17 Cédric Bosdonnat wrote:
Running the init on openSUSE and SLE machines showed up minor
errors:
* skip the /etc/mtab symlink creation if the file is already existing.
* make sure /run/lvm is created or lvmetab will complain.
---
appliance/init | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/appliance/init b/appliance/init
index 413a95f..b22032e 100755
--- a/appliance/init
+++ b/appliance/init
@@ -132,6 +134,7 @@ mdadm -As --auto=yes --run
# Scan for LVM.
modprobe dm_mod ||:
+mkdir -p /run/lvm
lvmetad ||:
In openSUSE 13.2 I see:
$ cat /usr/lib/tmpfiles.d/lvm2.conf
d /run/lock/lvm 0700 root root -
d /run/lvm 0700 root root -
which is part of the lvm2 package, thus copied into the appliance.
Later /init runs `systemd-tmpfiles --prefix=/dev --create --boot`...
which is told to handle files under /dev only. A simple fix would be:
-systemd-tmpfiles --prefix=/dev --create --boot
+systemd-tmpfiles --prefix=/dev --prefix=/run --create --boot
OTOH, I see that /run/lvm (and /run/lvm/lock) are created correctly in
my openSUSE VMs, so could you please provide more detail on the issue
you noticed?
Thanks,
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)