Re: [Libguestfs] [libnbd PATCH v2 12/12] tests: Language port of nbd_opt_set_meta_context() tests
On 08/31/22 16:39, Eric Blake wrote:
As promised in the previous patch, also test the new
nbd_opt_set_meta_context() API in Python, OCaml, and Golang.
The fact that Go slams all unit tests into the same namespace is
somewhat annoying; it required munging test 240 now that 250 wants to
use similar global variables.
---
python/t/250-opt-set-meta.py | 126 ++++++++++++
ocaml/tests/Makefile.am | 5 +-
ocaml/tests/test_250_opt_set_meta.ml | 150 ++++++++++++++
tests/opt-set-meta.c | 1 +
golang/Makefile.am | 3 +-
golang/libnbd_240_opt_list_meta_test.go | 54 +++---
golang/libnbd_250_opt_set_meta_test.go | 248 ++++++++++++++++++++++++
7 files changed, 558 insertions(+), 29 deletions(-)
create mode 100644 python/t/250-opt-set-meta.py
create mode 100644 ocaml/tests/test_250_opt_set_meta.ml
create mode 100644 golang/libnbd_250_opt_set_meta_test.go
git-am reports the following whitespace errors on this patch:
.git/rebase-apply/patch:579: space before tab in indent.
t.Fatalf("unexpected structured replies state")
.git/rebase-apply/patch:586: space before tab in indent.
t.Fatalf("unexpected can meta context state")
.git/rebase-apply/patch:651: space before tab in indent.
t.Fatalf("unexpected can meta context state")
.git/rebase-apply/patch:672: space before tab in indent.
t.Fatalf("unexpected can meta context state")
.git/rebase-apply/patch:692: space before tab in indent.
t.Fatalf("unexpected can meta context state")
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
Laszlo