Re: [Libguestfs] [nbdkit PATCH 3/5] api: Add nbdkit_string_intern helper

>> -      keys[optind] = strndup (argv[optind], n); >> -      if (keys[optind] == NULL) { >> -        perror ("strndup"); >> +      CLEANUP_FREE char *key = strndup (argv[optind], n); >> +      const char *safekey = nbdkit_string_intern (key); >> +      if (safekey == NULL) >>           exit (EXIT_FAILURE); > > It seems it might also be nice to have a "strndup" version of the > intern function. Or even a memdup.  Yeah, those are possibilities as well.  Doing all three (strdup, strndup, memdup) up front isn't hard.  If API proliferation is a problem, you can combine strdup and strndup by accepting -1 as a length to mean stop at NUL termination; but I'm less worried about API proliferation and more about ease-of-use.