Re: [Libguestfs] [PATCH RFC] sysprep:add logging feature
On Tue, Apr 03, 2012 at 04:54:59PM +0800, Wanlong Gao wrote:
On 04/03/2012 04:45 PM, Richard W.M. Jones wrote:
> On Tue, Apr 03, 2012 at 04:20:28PM +0800, Wanlong Gao wrote:
>> Hi Rich,
>>
>> What I felt at using virt-sysprep is that all things are done in silent and
>> there is no log what's done. Please consider to add logging feature what was
done
>> at virt-sysprep. For example,
>
> If we do logging, let's allow it to be enabled and disabled on the
> command line, and add a generic "log" function to utils.ml.
what I'm going to do and what we most interested in is,
- external guest fish script.
Does the new --script option do what you want? Note it's a shell
script, not a guestfish script (but a shell script should be more
flexible).
http://libguestfs.org/virt-sysprep.1.html#script
- homedir .ssh directroy
(It's better if virt-sysprep can prepare a new key for copied guest.)
- /var/run files
This would be simple, *except* that you need to avoid deleting
/var/run/lock.
- modify file system's UUID to be an unique.
Not hard, but complicated to ensure that all of the places that the
UUID is used have been updated (/etc/fstab obviously, but maybe there
are other places).
Other than that, I think following should be removed..
- .bash_history file
- delete user accounts (should be optional??)
- add/modify user accounts(optional)
-
Agreed. I think most of these are in the TODO file, they just need
doing ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org