Re: [Libguestfs] [PATCH] daemon: copy entire lvm directory
On Fri, Jan 18, Richard W.M. Jones wrote:
On Thu, Jan 17, 2013 at 02:14:00PM +0000, Richard W.M. Jones wrote:
> On Wed, Jan 02, 2013 at 04:13:06PM +0100, Olaf Hering wrote:
> > cp will fail if /etc/lvm is an empty directory. Copy the entire
> > directory and adjust environment variable.
>
> Thanks - pushed. I changed the whitespace and removed some
> unnecessary parens in this line:
>
> > + snprintf(env, sizeof(env), "%s/lvm", lvm_system_dir);
Actually this breaks the lvm_set_filter test and clearing the LVM
cache (since they expect to find lvm_system_dir/lvm.conf but the file
has now moved to lvm_system_dir/lvm/lvm.conf). I added this patch to
fix it:
Sorry for that, and thanks for the followup fix.
Olaf