Re: [Libguestfs] [virt-v2v wave 2 PATCH v2 00/16] replace QXL (and Cirrus) with standard VGA

On Thu, Dec 02, 2021 at 10:13:29AM +0000, Richard W.M. Jones wrote: I pushed my refactoring on top. This removes the separate helper-* programs which were an interesting experiment but not in the end very useful. The longer story behind this is described in this commit message: https://github.com/libguestfs/virt-v2v/commit/5609c73c615a8f12c5c6d50908b... The input and output modules use a new-ish (< 10 years) feature called first class modules. I found this tutorial useful: https://dev.realworldocaml.org/first-class-modules.html We're not using all the features there by any means, just a single feature which allows us to assign the OCaml Input.* or Output.* module to a name based on the -i/-o flag. You'll see what I mean in these two commits: https://github.com/libguestfs/virt-v2v/commit/724ecb5e887e5b71db836143ec0... https://github.com/libguestfs/virt-v2v/commit/4de22686fe74e1711efd9bfed3f... My next steps today are: - Do an upstream release (1.45.92) - Do a Fedora release - Do a RHEL 9 rebase/release - Split up the large input/input.ml and output/output.ml files into separate files. Now we have the modules we no longer need these to be single huge files, and having smaller files should make the code easier to navigate and each mode self-contained. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html