Re: [Libguestfs] [PATCH v2v] vddk: Use blocksize filter to split very large requests

On Tue, Feb 15, 2022 at 01:43:01PM +0000, Richard W.M. Jones wrote: Some test results can be found in this bug, unfortunately in private comments. I'll reproduce relevant excerpts below. As you can see this change + 8M block size approximately doubles the copying performance and brings it roughly in line with virt-v2v 1.45.3. https://bugzilla.redhat.com/show_bug.cgi?id=2039255 <quote> 1. Convert a guests from ESXi7.0 to rhv(rhv-upload) via vddk7.0.2 with rhv-direct=true to compare the performance between virt-v2v-1.45.98-1 and virt-v2v-1.45.3-3 v2v_version esx7.0-vddk7.0.2-rhv-upload-rhv-direct_true 1.45.98-1 Convert guest: 2m19s Copying disk: 8m18s 1.45.3-3 Convert guest: 2m5s Copying disk: 4m28s virt-v2v-1.45.98-1.el9.bz2039255.3: - Increases nbdcopy --requests to 1024 - Increases nbdcopy --request-size to 8M - Introduces the blocksize filter to prevent VMware problems related to above changes: https://listman.redhat.com/archives/libguestfs/2022-February/msg00211.html I think the performance has been improved by virt-v2v-1.45.98-1.el9.bz2039255.3 Test the bug with virt-v2v-1.45.98-1.el9.bz2039255.3.x86_64 Steps: 1. Convert a guests from ESXi7.0 to rhv(rhv-upload) via vddk7.0.2 with rhv-direct=true by v2v v2v_version esx7.0-vddk7.0.2-rhv-upload-rhv-direct_true 1.45.98-1 Convert guest: 2m15s Copying disk: 4m54s 1.45.3-3 Convert guest: 2m5s Copying disk: 4m28s </quote> Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW