Re: [Libguestfs] [Qemu-devel] [PATCH 1/5] nbd: Improve per-export flag handling in server

23.08.2019 17:37, Eric Blake wrote: > When creating a read-only image, we are still advertising support for > TRIM and WRITE_ZEROES to the client, even though the client should not > be issuing those commands. But seeing this requires looking across > multiple functions: >

> @@ -458,10 +458,13 @@ static int nbd_negotiate_handle_export_name(NBDClient *client, > return -EINVAL; > } > > - trace_nbd_negotiate_new_style_size_flags(client->exp->size, > - client->exp->nbdflags | myflags); > + myflags = client->exp->nbdflags; > + if (client->structured_reply) { > + myflags |= NBD_FLAG_SEND_DF; > + } why we cant do just client->exp->nbdflags |= NBD_FLAG_SEND_DF ?