Re: [Libguestfs] [libnbd PATCH] api: Add LIBNBD_SHUTDOWN_IMMEDIATE flag

> I think for the reasons you've outlined here it's fine to > change this from cmd_flags to shutdown_flags.  And the new > flag looks useful. > > Patch looks good, so ACK. I'm leaning towards having the flag value be 0x10000 (that is, outside the range of cmd flags).  Once we release with a value, it becomes locked into the API; but by intentionally picking something other than 0x1, we still leave room for ABI to take command flags at a later date, with a little less hassle than having to translate from LIBNBD_SHUTDOWN_FOO to LIBNBD_CMD_FLAG_FOO.