On 9/17/20 8:27 AM, Eric Blake wrote:
I think for the reasons you've outlined here it's fine to change this from cmd_flags to shutdown_flags. And the new flag looks useful.
Patch looks good, so ACK.
I'm leaning towards having the flag value be 0x10000 (that is, outside the range of cmd flags). Once we release with a value, it becomes locked into the API; but by intentionally picking something other than 0x1, we still leave room for ABI to take command flags at a later date, with a little less hassle than having to translate from LIBNBD_SHUTDOWN_FOO to LIBNBD_CMD_FLAG_FOO.
I'm also going to rename this LIBNBD_SHUTDOWN_ABANDON_PENDING, to make it a little more accurate to what it does -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org