Re: [Libguestfs] [PATCH nbdkit 2/2] file: Allow a file descriptor to be passed to the plugin

This is what I pushed - how does it look? I ignored the cases we cannot deal with, except O_WRONLY where I emit a debug message but continue: https://gitlab.com/nbdkit/nbdkit/-/blob/master/plugins/file/file.c#L572 > > > > There's also the case where r == O_WRONLY which the plugin (and NBD) > > cannot deal with. Not sure what to do about that - error? > > Or allow it, but with the caveat that every NBD_CMD_READ will fail. > The only reason to special case h->can_write=false for O_RDONLY is > because then we don't advertise it to the client; to save them from > getting failures on NBD_CMD_WRITE - but that's because it is an easy > thing to advertise. Advertising that NBD_CMD_READ will fail is not > easy (and less likely to happen in practice), so failing to serve the > file is just as viable as serving it and letting every NBD_CMD_READ > fail. That's basically what I did, plus a debug message :-)