Re: [Libguestfs] [PATCH] pod: Use F<> for filenames instead of C<>.

On Sunday 14 June 2015 14:37:26 Richard W.M. Jones wrote: > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -615,7 +615,7 @@ against. > Note that because of dynamic linking this is not necessarily > the version of libguestfs that you compiled against. You can > compile the program, and then at runtime dynamically link > -against a completely different C<libguestfs.so> library. > +against a completely different F<libguestfs.so> library. > > This call was added in version C<1.0.58>. In previous > versions of libguestfs there was no way to get the version > @@ -830,7 +830,7 @@ to specify the QEMU interface emulation to use at run time." }; > ]; > shortdesc = "detect the architecture of a binary file"; > longdesc = "\ > -This detects the architecture of the binary C<filename>, > +This detects the architecture of the binary F<filename>, > and returns it if known. (and other similar cases here in actions.ml) Considering that "filename" is the name of parameter, shouldn't it be better left with C<>?

> @@ -81,9 +81,9 @@ C<VIRT_P2V_DATA_DIR> environment variable. > > =item C<$datadir/issue> > > -=item C<$datadir/launch-virt-p2v.in> > +=item F<$datadir/launch-virt-p2v.in> > > -=item C<$datadir/p2v.service> > +=item F<$datadir/p2v.service> I guess C<$datadir/issue> too?

The rest seems fine to me. Thanks, -- Pino Toscano _______________________________________________ Libguestfs mailing list Libguestfs(a)redhat.com https://www.redhat.com/mailman/listinfo/libguestfs