Re: [Libguestfs] [nbdkit PATCH 6/7] nbd: Implement NBD_OPT_GO client request

So patches 1-6 are fine. I'm not in a position to say whether patch 3 is required or not, but I have no objection to it either way. Patch 7 seems to have a leak, but apart from that is also fine. About memset-ing the buffer before passing it to plugin .pread methods, I'll send you a patch for that in a minute. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW