Re: [Libguestfs] [PATCH v2] lib: add support for disks with 4096 bytes sector size

I pushed this with some trailing whitespace fixes, and I dropped the change to tmp/.gitignore since the test does clean up after itself. I also fixed test-qemu-drive-with-blocksize-libvirt.sh so it doesn't actually open /dev/sda etc on the host (don't run tests as root!) However ... We already use blocksize as an optional parameter to mkfs. While they don't directly conflict, it is confusing. Is there a reason we shouldn't call this new parameter "sectorsize"? We can change the parameter name any time up til we make the next stable release. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top