Re: [Libguestfs] [PATCH v2] Revert "launch: libvirt: Use qemu-bridge-helper to implement a full network (RHBZ#1148012)."
On Mon, Jan 07, 2019 at 12:26:38PM +0100, Pino Toscano wrote:
On Thursday, 6 December 2018 16:47:32 CET Richard W.M. Jones wrote:
> We've been carrying this exact patch in RHEL 7 for several years. It
> reverts the change made in 2014 where we switched to using the virbr0
> bridge for libguestfs networking instead of SLIRP. We thought SLIRP
> was going to become unsupported in qemu, but recently there have been
> more encouraging signs since it looks like SLIRP will be spun off as a
> separate project, running as a modular process and properly secured
> and supported.
>
> This reverts commit 224de20b9a8d5ea56f6337f19b4ca237bb88eca0.
> ---
I gave this patch a try for a while, and it seems working fine so far.
Maybe it is too close to 1.30, though?
Heh, I just hit this bug *again* minutes ago (because I've got a new
laptop which didn't have the libvirt-whatever-network package
installed).
I _do_ think we should include this in 1.40.
I'm going to try to do 1.40 today. There are still a few bugs in
check-slow, but nothing too serious and I've fixed a lot of them
already and I don't want to wait any longer.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html