Re: [Libguestfs] v2v: -i libvirtxml: Map empty network or bridge name to a default (RHBZ#1257895).
On Fri, Aug 28, 2015 at 04:00:34PM +0200, Pino Toscano wrote:
In data venerdì 28 agosto 2015 14:19:05, Richard W.M. Jones ha
scritto:
> When importing from VMware via the libvirt driver, the libvirt driver
> can add an empty source bridge name:
>
> <interface type='bridge'>
> <mac address='00:01:02:03:04:05:06'/>
> <source bridge=''/>
> </interface>
>
> Replicate what we do on the -i ova path, and map these to "eth0",
> "eth1" etc.
LGTM.
> This also includes a bunch of changes to how we do xpath parsing to
> make it type-safe.
Could patches 2/4/5 be squashed together?
Yup - totally they could. I just thought they'd be a bit easier to
review this way. I'll squash them before committing.
Thanks,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/