Re: [Libguestfs] [PATCH 1/3] New API: mdadm-create for creating MD devices.
Hi Richard:
On Wed, Nov 16, 2011 at 08:29:55AM +0800, Wanlong Gao wrote:
>> I wasn't sure if you meant (a) remove the use of the constant here and
>> replace it with a macro, or (b) allow users to specify other chunk
>> sizes (eg. less than 1024 bytes, or not a multiple of 1024 bytes).
[...]
> I meant (a) just for the code readable and the future maintenance?
OK, understood!
I'm happy about 'chunk & 1023' since I know that 1024 bytes = 1K. Do
you have a suggested symbol / macro that would make this clearer?
No. I defer to your great knowledge in libguestfs. So, it's up to you.
BTW: I wanna know what can we do for the liguestfs to help your dev?
just follow the *TODO* list?
Thanks
-Wanlong Gao
Rich.