Re: [Libguestfs] another GTK3 regression...
On 09/30/22 13:01, Laszlo Ersek wrote:
... meant to add: this has proved Daniel's point that the WM is
extremely important. For the record, I use IceWM locally, so when I
run virt-p2v "directly", on my workstation, and forward X11 over SSH,
the reason for me seeing the spinner in the GTK3 build *may be* that I
use IceWM locally. It's possible that, if I used metacity locally, the
spinner would not work for me even in this X11-over-SSH setup.
Also I reckon Rich does not use metacity -- originally a gtk2-based
window manager -- on his laptop, but the gnome shell. gnome shell
could similarly eliminate the issue. (Assuming we agree that the issue
is *in* metacity.)
So, for Rich, the spinner works, when metacity comes from Fedora 36.
Considering Koji:
https://koji.fedoraproject.org/koji/packageinfo?packageID=143
Fedora 35 is based on upstream metacity 3.42.0, while Fedora 36 is on
3.44.0:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1853336
https://koji.fedoraproject.org/koji/buildinfo?buildID=1936492
(I've checked in the VM disk image -- it indeed contains
"metacity-3.42.0-1.fc35".)
Now, the upstream commit range between 3.42.0 and 3.44.0 is really
small:
1 ba192a82b2e9 revert "ci: use ubuntu 21.04 image"
2 1e0b9611551b Update Croatian translation
3 503fca976051 Update Croatian translation
4 9ed3b103f6ad bump version to 3.43.1, update NEWS
5 1b052f6f8675 build: remove obsolete macros
6 b3ca2a83da79 bump version to 3.44.0, update NEWS
And the fedora package contains no downstream patches AFAICT.
So this does not explain why metacity works, when Rich builds the VM
disk image from Fedora 36 :/
There are much more interesting updates *after* 3.44.0:
1 a3feabd50d46 icon-cache: remove support for KWM_WIN_ICON
2 7c1cc3ca1d81 window: remove incorrect mask check
3 4ea95a3b1cc3 icon-cache: make get_icon_invalidated static
4 94be8fa628e3 icon-cache: reset origin if property change invalidates icon
5 cb83bc33d32b Update Basque translation
6 5e60b4201624 Update German translation
7 bd2239178a9f Update Turkish translation
8 9eb4213af557 Update Georgian translation
9 de8ced755bff Update Turkish translation
But those are not part of even rawhide at the moment.
Laszlo