Re: [Libguestfs] [PATCH 2/2] sparsify: handle output filenames with ':'

With commit a594b7f90a682e2a9327b142138edb76ad8ba8ff the checks for input and output files with ':' were removed; while the input file is handled correctly by the disk_create API, an output filename with ':' could still be handled as specifying a transport, failing the last "qemu-img convert" call. Use the new qemu_input_filename helper to handle the output filename correctly. --- sparsify/copying.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sparsify/copying.ml b/sparsify/copying.ml index 3628b01..d4861f9 100644 --- a/sparsify/copying.ml +++ b/sparsify/copying.ml @@ -311,7 +311,7 @@ You can ignore this warning or change it to a hard failure using the (match option with | None -> "" | Some option -> " -o " ^ quote option) - (quote overlaydisk) (quote outdisk) in + (quote overlaydisk) (quote (qemu_input_filename outdisk)) in if verbose then printf "%s\n%!" cmd; if Sys.command cmd <> 0 then