Re: [Libguestfs] [PATCH v2 1/7] lib: Share common protocol and errnostring libraries with the library and daemon.
On Thu, Jan 26, 2017 at 04:57:32PM +0100, Pino Toscano wrote:
On Wednesday, 25 January 2017 14:37:10 CET Richard W.M. Jones wrote:
> This commit, which is just code motion, moves the common XDR protocol
> code (libprotocol) and the common errno handling (liberrnostring) into
> libraries which are each built once and shared between the library and
> daemon.
> ---
> guestfsd_SOURCES = \
> + ../common/errnostring/errnostring.h \
> + ../common/protocol/guestfs_protocol.h \
> [...]
> libguestfs_la_SOURCES = \
> + ../common/errnostring/errnostring.h \
> + ../common/protocol/guestfs_protocol.h \
Are these two changes needed? The targets already depend on the .la.
It's a bit unclear TBH. However those files are both explicitly
included in the respective programs, eg:
$ git grep errnostring.h -- daemon
daemon/proto.c:#include "errnostring.h"
I'm not sure if you're supposed to specify every .h file in _SOURCES
or only ones in the same directory or if it doesn't matter. The
automake documentation seems to suggest it doesn't really matter
beyond the implicit addition to EXTRA_DIST:
Header files listed in a ‘_SOURCES’ definition will be included in
the distribution but otherwise ignored. In case it isn’t obvious, you
should not include the header file generated by ‘configure’ in a
‘_SOURCES’ variable; this file should not be distributed.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/