Re: [Libguestfs] [PATCH v3.1 1/9] uuid: add support to change uuid of btrfs partition
-----Original Message-----
From: libguestfs-bounces(a)redhat.com [mailto:libguestfs-bounces@redhat.com] On
Behalf Of Pino Toscano
Sent: Friday, June 26, 2015 8:12 PM
To: libguestfs(a)redhat.com
Subject: Re: [Libguestfs] [PATCH v3.1 1/9] uuid: add support to change uuid of btrfs
partition
In data venerdì 26 giugno 2015 17:35:36, Chen Hanxiao ha scritto:
> btrfs-progs v4.1 add support to change uuid of btrfs fs.
>
> Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com>
> ---
> v3.1: fix a typo
> v3: set errno as ENOTSUP when btrfstune -u is not available
> v2: put btrfs operation back to daemon/btrfs.c
> move tests to tests/btrfs
>
> daemon/btrfs.c | 60 ++++++++++++++++++++++++++++++++++++++++++
> daemon/daemon.h | 1 +
> daemon/uuids.c | 6 ++---
> tests/btrfs/test-btrfs-misc.pl | 17 ++++++++++++
> 4 files changed, 80 insertions(+), 4 deletions(-)
>
> diff --git a/daemon/btrfs.c b/daemon/btrfs.c
> index 20e5e6b..a69c512 100644
> --- a/daemon/btrfs.c
> +++ b/daemon/btrfs.c
> @@ -790,6 +790,44 @@ do_btrfs_device_delete (char *const *devices, const char
*fs)
> return 0;
> }
>
> +
> +/* btrfstune command add two new options
> + * -U UUID change fsid to UUID
> + * -u change fsid, use a random one
> + * since v4.1
> + * We could check wheter 'btrfstune' support
> + * '-u' and '-U UUID' option by checking the output of
> + * 'btrfstune' command.
> + */
> +static int
> +test_btrfstune_uuid_opt (void)
> +{
> + static int result = -1;
> + if (result != -1)
> + return result;
> +
> + CLEANUP_FREE char *err = NULL;
> +
> + int r = commandr (NULL, &err, str_btrfstune, NULL);
> +
> + if (r == -1) {
> + reply_with_error ("btrfstune: %s", err);
> + return -1;
> + }
> +
> + /* FIXME currently btrfstune do not support '--help'.
So --help should be passed anyway to the btrfstune invocation, so with
newer versions hopefully there will not be complaints about it anymore.
Fine.