Re: [Libguestfs] [PATCH] lua: always return luaL_error in actions

Even if luaL_error is a "no return" function for the Lua runtime, adopt also in action functions the "return" idiom recommeded for it. This also helps code analyzers in not thinking that "g" might still be null after the null check followed by luaL_error. --- generator/lua.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/generator/lua.ml b/generator/lua.ml index 9bd4006..5d5619c 100644 --- a/generator/lua.ml +++ b/generator/lua.ml @@ -482,8 +482,8 @@ guestfs_lua_delete_event_callback (lua_State *L) pr "\n"; pr " if (g == NULL)\n"; - pr " luaL_error (L, \"Guestfs.%%s: handle is closed\",\n"; - pr " \"%s\");\n" name; + pr " return luaL_error (L, \"Guestfs.%%s: handle is closed\",\n"; + pr " \"%s\");\n" name; pr "\n";