Re: [Libguestfs] [PATCH 0/2] virt-builder OpenSUSE images

Hi Cédric, On Tuesday 08 September 2015 09:40:21 Cédric Bosdonnat wrote: > Here are two patches to get opensuse images in virt-builder. > > Cédric Bosdonnat (2): > Allow curl to follow redirects. > builder: add opensuse images sources > > builder/Makefile.am | 3 ++- > builder/downloader.ml | 4 ++-- > builder/opensuse.conf.in | 3 +++ > builder/opensuse.gpg | 21 +++++++++++++++++++++ > configure.ac | 1 + > 5 files changed, 29 insertions(+), 3 deletions(-) > create mode 100644 builder/opensuse.conf.in > create mode 100644 builder/opensuse.gpg Really nice work! Both patches LGTM. The only problem is that patch #2 does not apply cleanly after my SimpleStreams work for virt-builder, so can you please rebase it? I just pushed patch #1, which applies fine. I gave the images a try, and a couple of notes so far are: - mllib/passwords.ml:default_crypto does not know about opensuse, so assumes md5 for shadow (there's a warning when setting up passwords); should be easy to fix

- none of the images then boot, reporting that /sbin/init cannot be executed, with error -28.