Re: [Libguestfs] do_umount adjustment

Richard W.M. Jones wrote: No need for ugliness after all. Here's a more faithful new version: /* Again, use the external /bin/umount program, so that /etc/mtab * is kept updated. */ int do_umount (const char *pathordevice) { int r; char *err; char *buf = (strncmp (pathordevice, "/dev/", 5) == 0 ? strdup (pathordevice) : sysroot_path (pathordevice)); if (buf == NULL) { reply_with_perror ("malloc"); return -1; } r = command (NULL, &err, "umount", buf, NULL); free (buf); if (r == -1) { reply_with_error ("umount: %s: %s", pathordevice, err); free (err); return -1; } free (err); /* update root_mounted? */ return 0; }