Re: [Libguestfs] [PATCH] sparsify: Fix test-virt-sparsify-in-place-fstrim-unsupported.sh

Since Linux commit f663b5b38fff trimming vfat is now supported by Linux. This broke the test which assumed it was not supported. Use another filesystem (minix) which does not support trimming instead. Thanks: Daniel P. Berrangé and Pino Toscano. --- ...virt-sparsify-in-place-fstrim-unsupported.sh | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sparsify/test-virt-sparsify-in-place-fstrim-unsupported.sh b/sparsify/test-virt-sparsify-in-place-fstrim-unsupported.sh index ff7dab3fa..e2b2e9c20 100755 --- a/sparsify/test-virt-sparsify-in-place-fstrim-unsupported.sh +++ b/sparsify/test-virt-sparsify-in-place-fstrim-unsupported.sh @@ -21,13 +21,11 @@ # # https://bugzilla.redhat.com/show_bug.cgi?id=1364347 # -# This test assumes that the kernel vfat driver does not support +# This test assumes that the kernel minix driver does not support # fstrim. It might become supported in a future kernel version in # which case we could use a different filesystem for this test, or # delete the test if we are confident that all common filesystems are # supported.

-# Create a test filesystem with a single vfat filesystem. -guestfish -N $img=fs:vfat exit +# Create a test filesystem with a single minix filesystem. If this +# fails, skip the test under the assumption that (like with Enterprise +# Linux systems) Minix is not supported. +guestfish -N $img=fs:minix exit || { + echo $0: skipping the test because Minix filesystems are not supported + exit 77 +}