Re: [Libguestfs] [p2v PATCH 1/4] Makefile.am: factor out "make-physical-machine.sh"

On 08/26/22 14:39, Eric Blake wrote: I had grepped the virt-p2v and virt-v2v shell scripts for shebangs: 1 #!/bin/sh 2 #!/bin/bash 4 #!/usr/bin/env perl 17 #!/bin/bash - 1 #!/bin/bash 1 #!/usr/bin/env python3 1 #!/usr/bin/sh 5 #!/usr/bin/env perl 67 #!/bin/bash - The thinking seems to have been that - python3 and perl may "move", - bash is considered always available. So I wouldn't break consistency with "#!/bin/bash". I did feel like breaking consistency with the hyphen "#!/bin/bash -" -- in that, minimally, I would write "#!/bin/bash --". Anyway, as a temporary approach, I just stuck with the tradition (the hyphen), and ended up posting the patch like that. It's not "wrong" technically, just strange to my taste. I no longer feel strongly about it (but I'm happy to remove the hyphen if that's desired). Can you please elaborate? POSIX writes, "When a function is executed, it shall have the syntax-error and variable-assignment properties described for special built-in utilities in the enumerated list at the beginning of Special Built-In Utilities", and I've checked that list -- I don't know what you mean. Yes, as EXIT covers those. Easy to test with: ------ #!/bin/bash cleanup() { echo done >zzz } trap cleanup EXIT sleep 100 ------ rm -f zzz ./hello.sh and then hitting either ^C or Alt-F4 in/on the terminal window. It's for a similar reason I didn't specify ERR -- ERR applies roughly under the same conditions where "set -e" causes the shell to exit, so "set -e" causes (in effect) the EXIT trap handler to cover ERR too. Laszlo