Re: [Libguestfs] [PATCH v2] RHBZ#1406906: check return value of Python object functions
On Thursday, 11 May 2017 20:21:39 CEST Matteo Cafasso wrote:
Verify the returned values of Python Object constructor functions
are not NULL before adding them to a collection.
This is particularly relevant when constructing Unicode strings in
Python 3 as they will return NULL if non UTF-8 characters are present.
Signed-off-by: Matteo Cafasso <noxdafox(a)gmail.com>
---
LGTM -- the only thing to change is the first line of the commit
message, which should be like "python: ... (RHBZ#...)". Not going to
ask you to respin a v3 just because of that, though.
Amended, and pushed. I will close the bug soon too.
Thanks,
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)