Re: [Libguestfs] [PATCH] p2v: User can click on an interface name to identify the physical interface.

On Tuesday 26 January 2016 17:37:07 Richard W.M. Jones wrote: > On Tue, Jan 26, 2016 at 06:14:18PM +0100, Pino Toscano wrote: > > On Tuesday 26 January 2016 15:38:07 Richard W.M. Jones wrote: > > > When the user clicks on the second column of the list of network > > > interfaces, run 'ethtool --identify <if_name> 10', which (on supported > > > cards) flashes a light on the physical interface for 10 seconds, > > > allowing it to be identified by the operator. > > > > > > This has a nasty bit of hidden UI, basically because Gtk makes it near > > > impossible to put a regular button into a GtkTreeView. > > > --- > > > > Wouldn't it better than add a simple "Identify interface" next to the > > list? IMHO would be more explicit, and avoid spawning ethtool commands > > when not wanted. > > I think do you mean another column with a label [not a button, > unfortunately] marked "identify interface"? That is possible. Also > we could add that text to the Device column. Actually I meant outside the tree, placed on his right (or left on RTL layouts).