Re: [Libguestfs] [libnbd PATCH v2 06/13] api: Add nbd_opt_abort and nbd_aio_opt_abort
On Fri, Aug 14, 2020 at 05:00:25PM -0500, Eric Blake wrote:
diff --git a/lib/internal.h b/lib/internal.h
index 5f495fb..03baacd 100644
--- a/lib/internal.h
+++ b/lib/internal.h
@@ -101,6 +101,7 @@ struct nbd_handle {
/* Option negotiation mode. */
bool opt_mode;
+ uint8_t current_opt;
Be nice to add a comment here about what current_opt can contain,
which would also explain why it has this somewhat unexpected type.
Something like:
+ uint8_t current_opt; /* 0 or NBD_OPT_* */
(Can it only contain NBD_OPT_ABORT or are other options added in later
patches?)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org